Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift: Re-specify Qualitative colors for uplift. #3007

Closed
tmcconechy opened this issue Oct 21, 2019 · 14 comments · Fixed by #3298
Closed

Uplift: Re-specify Qualitative colors for uplift. #3007

tmcconechy opened this issue Oct 21, 2019 · 14 comments · Fixed by #3298
Assignees
Labels
design Needs input from IDS Design Team focus: dark mode dark mode focus: uplift theme Items related to completion the Uplift theme team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Oct 21, 2019

Is your feature request related to a problem? Please describe.
Some of the charts do not look that great when using the uplift theme. This is because the "Qualitative chart colors" elements were not reconsidered when adding the uplift new colors. Particular some of the colors are more similar and the turquoise03 is hard to see.

Describe the solution you'd like
Redesign slide 11 of the attached document to uplift theme. We can either change the soho ones and add a second list of uplift colors like the soho design slide.

Additional context
Noticible on http://latest-enterprise.demo.design.infor.com/components/bar/example-colors.html?theme=uplift&variant=light&colors=0563C2

See slide 11
soho_xi_BI_guidelines.pdf.zip

This is also mentioned on https://design.infor.com/resources/data-visualization-guidelines

Designs (Sketch)

IDS Colors Stress Test.sketch.zip

@tmcconechy tmcconechy changed the title Uplift: Respec quantitative colors for uplift. Uplift: Re-specify quantitative colors for uplift. Oct 21, 2019
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) design Needs input from IDS Design Team team: landmark For Landmark issues type: bug 🐛 labels Oct 21, 2019
@tmcconechy
Copy link
Member Author

@tmcconechy tmcconechy changed the title Uplift: Re-specify quantitative colors for uplift. Uplift: Re-specify Qualitative colors for uplift. Oct 21, 2019
@tmcconechy tmcconechy added this to To do in Enterprise 4.25.x (December 2019) Sprint via automation Dec 9, 2019
@tmcconechy
Copy link
Member Author

Moving this up as not quite done from design and the sprint ended.

@elizabethhartley
Copy link

@tmcconechy sorry — we'll be reviewing them tomorrow and then they should be ready for handoff

@tmcconechy
Copy link
Member Author

Not a problem, we will get them in as we can next sprint.

@brianjuan
Copy link

Found an issue that might be related to this since this is working fine in previous version (4.24).
Check is not visible in Calendar Uplift theme Dark variant.
http://master-enterprise.demo.design.infor.com/components/calendar/example-index.html?theme=uplift&variant=dark
image

Few observations - your call guys if need to be addressed.

  1. Color of disabled menus in contextmenu are hardly recognizable from the regular menus.
    http://master-enterprise.demo.design.infor.com/components/contextmenu/example-index.html?theme=uplift&variant=light
    image

  2. Colors of selected tools in Editor are too bright in Uplift theme Dark variant.
    http://master-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift&variant=dark
    image

@brianjuan brianjuan moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.25.x (December 2019) Sprint Jan 14, 2020
@elizabethhartley
Copy link

Hey Brian!

My understanding of the first issue is that the checkbox is disabled and therefore not checked nor clickable. The color, however, is a little dark — we should revisit it.

The second issue is indeed a problem. We'll have to address this when we look at re-assigning the tokens to new colors.

As for the third issue, I believe @kentonquatman is working on some new Text Editor designs — this might solve for this problem. If that won't be ready for a while we can change that color to a lighter blue when we circle back to more in-depth color QA.

Let me know what you think @kentonquatman @tmcconechy

@tmcconechy
Copy link
Member Author

Yes, i agree.

  1. Its not checked - but will update the example
  2. i can fix this for now
  3. i agree that the dark editor changes for the toolbar background dont 100% work maybe we should just set it back to what it was for now? I can make some tweaks and see. So i will address this a bit.

@brianjuan
Copy link

Hi Elizabeth and Tim, thanks for the clarification on disabled checkbox issue. With this, I think we should remove the check in Light and High Contrast as well.
Light
image
High Contrast
image

Noted on second and third issue. Thanks @elizabethhartley and @tmcconechy .

@elizabethhartley
Copy link

@brianjuan oh! yes you're right. good catch 👍

@kentonquatman
Copy link

Are company holidays always displayed on the calendar or always hidden?

@tmcconechy
Copy link
Member Author

tmcconechy commented Jan 15, 2020

@kentonquatman its really just a placeholder / example. They can configure the legend to whatever they want and provide whatever data they want for their company. So the legend is entirely an example based on faked data here. The issue is really just the disabled checkbox not working with one color in particular as you can also configure the legend checkbox colors http://latest-enterprise.demo.design.infor.com/components/checkboxes/example-legend-colors.html

I'll address a few things here asap.

@kentonquatman
Copy link

My comment was going to be that we will need a checked state for the dark theme. I would leave them checked and make sure the disabled works well in all three themes.

@tmcconechy
Copy link
Member Author

tmcconechy commented Jan 15, 2020

Yeah or maybe i just pick a different checkbox color than slate/graphite for the example (or a different slate/graphite value that works across all themes). On their own without the colorized versions we have a color for disabled in dark mode http://latest-enterprise.demo.design.infor.com/components/checkboxes/example-index.html?theme=uplift&variant=dark not sure if it needs tweaking but it is visible.

@tmcconechy tmcconechy moved this from Failed QA (beta) to In progress in Enterprise 4.25.x (December 2019) Sprint Jan 17, 2020
@tmcconechy tmcconechy moved this from In progress to Ready for QA (rc) in Enterprise 4.25.x (December 2019) Sprint Jan 21, 2020
@tmcconechy tmcconechy moved this from Ready for QA (rc) to Done in Enterprise 4.25.x (December 2019) Sprint Jan 21, 2020
@tmcconechy tmcconechy moved this from Done to Ready for QA (rc) in Enterprise 4.25.x (December 2019) Sprint Jan 21, 2020
@brianjuan
Copy link

All of the issues and observations above are now resolved in 4.25.0-rc0, tested in all browsers as well. This is now QA passed.

@brianjuan brianjuan moved this from Ready for QA (rc) to Done in Enterprise 4.25.x (December 2019) Sprint Jan 23, 2020
@tmcconechy tmcconechy added the focus: uplift theme Items related to completion the Uplift theme label Feb 4, 2020
@inforandy inforandy added the focus: dark mode dark mode label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs input from IDS Design Team focus: dark mode dark mode focus: uplift theme Items related to completion the Uplift theme team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants