Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Support draggable modal with no lightbox #2983

Closed
jamie-norman opened this issue Oct 15, 2019 · 18 comments
Closed

Modal: Support draggable modal with no lightbox #2983

jamie-norman opened this issue Oct 15, 2019 · 18 comments

Comments

@jamie-norman
Copy link

Description:
Support for draggable/floating action forms where the user can drag the action form to another part of the screen. In addition, remove the lightboxing so the user can clearly see details on the screen behind modal.

There are often cases where referencing info on the current screen is necessary to populate the action form.

Related to LMCLIENT ticket: https://jira.lawson.com/browse/LMCLIENT-27266

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) type: enhancement ✨ team: landmark For Landmark issues labels Oct 15, 2019
@tmcconechy tmcconechy changed the title Support draggable modal with no lightbox Modal: Support draggable modal with no lightbox Oct 15, 2019
@tmcconechy
Copy link
Member

The way i would do this is

  1. Add a setting Modal: Allow opacity of the overlay to be controlled by setting #2975 to control the opacity (set to zero for this case)
  2. Add the ability to drag the modal around by changing the cursor on the title. Note that this was done by @deep7102 in toast
  3. Do we save the position like toast?

@jamie-norman
Copy link
Author

  1. I think saving the position would be a good idea; probably expected by the user as long as it's open.

I think there may be an opportunity to explore a dockable option for a "notes" kind of modal from the use case in the LMCLIENT ticket. I can see that having utility.

@tmcconechy
Copy link
Member

Ok we dont have anything like that but maybe by remembering the position it could serve the purpose if they move it to the side when dragging.

@adinenno
Copy link

I agree with remembering the position where you drug it if you leave the screen and come back in.

@EdwardCoyle
Copy link
Contributor

Per @jamie-norman's comment:

I think there may be an opportunity to explore a dockable option for a "notes" kind of modal from the use case in the LMCLIENT ticket. I can see that having utility.

To me, this sounds pretty similar to how the email composition was in Google Inbox, or how the messaging system in webapps like LinkedIn or Facebook works, where:

  • There's a "taskbar" kind of element on one edge of the page that serves as the dockable area.
  • The user can establish multiple windows that have different visible states. There's always one that currently "working" or "in use", while the rest are "minimized". They would also be dismissible
  • The "in-use" window can be expanded or shrunk with pre-defined degrees of size to get a look at the information behind it, if necessary (in the context of Inbox, this was to get a look at the conversation. On LinkedIn, it may be to read an article or a profile before you message someone). This means that by default, there is no opacity overlay in this type of UI.

This solution sounds better to me than draggable dialog windows. Soho/IDS has avoided implementing these on purpose in the past, largely to stay away from creating environments where multiple, forms heavy dialogs could be opened at once. Draggable windows also don't work well in mobile or mobile/desktop hybrid environments, where screen real-estate may not be present to handle them. I'd propose building out something like this over changing our Modal, which by definition would no longer be "modal" with the proposed changes.

@jamie-norman
Copy link
Author

I like your thoughts Ed. I also think it could potentially lead us down a slippery slope with lots of action forms moving to a minimizable, docking component. We will have to think about use cases and some guidelines for when it's advisable and when UX would suffer.

@adinenno
Copy link

I think the key to the use case I put in the LMCLIENT JIRA is that the user wants to go to other locations in the application while writing the note to do research relevant to writing the note.

@tmcconechy
Copy link
Member

Yeah if thats the actual use case having a draggable modal doesnt solve much and in fact if you navigate away the modal will close y the angular router. So we would need something more at the application level with a special area that stays put. Not sure how this would look. Maybe a new page pattern. If it works on any page that could get pretty complicated.

@tmcconechy tmcconechy added [∞] Velocity rating (Fibonacci) and removed team: landmark For Landmark issues [5] Velocity rating (Fibonacci) labels Oct 15, 2019
@jamie-norman
Copy link
Author

Another place for this to live—the notes example anyway—would be a contextual app piece in mingle

@tmcconechy
Copy link
Member

Yeah that makes more sense to me. Just dragging the modal around would only let you access things on that page under the modal.

@adinenno
Copy link

Jamie just showed me how this would work and I think that this approach could definitely work and accomplish this use case. It's a more innovative approach too.

@tmcconechy
Copy link
Member

Ok, i'll keep this issue open for adding drag to the modal as that has been an ask. Although not this exact use case.

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) and removed [∞] Velocity rating (Fibonacci) labels Oct 15, 2019
@adinenno
Copy link

okay can someone send me the new number?

@tmcconechy
Copy link
Member

Sounds like what you will do is add a widget in a contextual app piece in mingle. If so thats something your team will have to do. And nothing that needs to go in the components. You would just build out an contextual widget and work with the mingle team on how to do that.

So no issue for us.

@adinenno
Copy link

Oh, so Mary Pat's application development team does this?

@tmcconechy
Copy link
Member

I guess. Whoever does mingle widgets for your team? Not this team tho.

@tmcconechy tmcconechy added the team: landmark For Landmark issues label Oct 15, 2019
@tmcconechy
Copy link
Member

I decided we should close this for now. As its not solving any issue for the requesting team.
Also we previously decided not to add dragging to modals as its working around UX issues with a bad usability. And will not work on mobile.

Enterprise 4.24.x (November 2019) Sprint (NG 6.3) automation moved this from To do to Done Oct 16, 2019
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Aug 3, 2022
@tmcconechy tmcconechy moved this from Triage to Check Back in Enterprise (Next) Sprint Grooming Aug 3, 2022
@tmcconechy tmcconechy removed this from Check Back in Enterprise (Next) Sprint Grooming Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: landmark For Landmark issues type: enhancement ✨ wontfix [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

4 participants