Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all Soho References to Ids #1682

Closed
5 tasks
tmcconechy opened this issue Feb 26, 2019 · 2 comments
Closed
5 tasks

Rename all Soho References to Ids #1682

tmcconechy opened this issue Feb 26, 2019 · 2 comments
Labels
focus: refactor Label for tasks we should include for a major release refactor type: breaking change 💥 [5] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Feb 26, 2019 •
edited

Is your feature request related to a problem? Please describe.

Noticing that the main Soho object has the older branding. For example Soho.Locale.
This should probably be changed to Ids.Locale. We can do this with out breaking too much with the migrate script.

Describe the solution you'd like

  • Change the global to https://github.com/infor-design/enterprise/blob/master/rollup.config.js#L19
  • Add a pointer to point Soho to Ids Soho = Ids in soho-migrate.js for better compatibility
  • Change the script names and build scripts to rename sohoxi.js to ids.js
  • Find any (886) references to Soho. whatever in the code and rename and adjust as needed
  • What about NG? Rename all Soho to Ids 😨 ?

Describe alternatives you've considered
CC @EdwardCoyle
@tmcconechy tmcconechy added this to the Focus: Evolution v5.0.x milestone Feb 26, 2019
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) and removed [3] Velocity rating (Fibonacci) type: maintenance 🛠️ labels Feb 26, 2019
@clepore clepore removed this from the Focus: Evolution v5.0.x milestone Jun 11, 2019
@tmcconechy
Copy link
Member Author

Similar to #1199 -> should consolidate these once we decide

@tmcconechy tmcconechy added this to To do in Enterprise 4.28.x (April 2020) Sprint via automation Feb 7, 2020
@tmcconechy tmcconechy added the focus: refactor Label for tasks we should include for a major release refactor label Jun 22, 2020
@tmcconechy
Copy link
Member Author

A future major version 6.0 or 5.0 we are starting to do gradually do this. no need to keep an issue open for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: refactor Label for tasks we should include for a major release refactor type: breaking change 💥 [5] Velocity rating (Fibonacci)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clepore @tmcconechy