Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid Tree - Make Filtered child rows a setting #1422

Closed
tmcconechy opened this issue Dec 18, 2018 · 2 comments
Closed

Datagrid Tree - Make Filtered child rows a setting #1422

tmcconechy opened this issue Dec 18, 2018 · 2 comments
Assignees
Labels
type: enhancement ✨ [5] Velocity rating (Fibonacci)
Milestone

Comments

@tmcconechy
Copy link
Member

Describe the bug
As a continuation on #1281

To Reproduce
Steps to reproduce the behavior:
Behavior number 2 still happens when you apply filter that match the parent node. Expand/collapse button is displayed but doesn't do anything.
Steps:

Expected behavior
Make this behavior a setting.

Add this as api settings allowChildExpandOnMatch: boolean

allowChildExpandOnMatch === true

  • if only parent got match then add children nodes too

  • if one or more child node got match then add parent node and all the children nodes
    allowChildExpandOnMatch === false

  • if only parent got match then (disable|hide|anything-else) +/- button and no add children nodes

  • if one or more child node got match then add parent node and only matching children nodes (as it doing now)

Additional context
#1281

@tmcconechy
Copy link
Member Author

Added to the sprint as Deepak is done with all the issues (except infor-design/enterprise-ng#206 which may not be possible) and he was working on fixing this.

@janahintal
Copy link
Contributor

janahintal commented Jan 18, 2019

QA Passed.
Tested in: http://localhost:4000/components/datagrid/test-tree-filter-child-on-match.html for all Browsers, OS and devices

@janahintal janahintal moved this from Ready For QA to Done in Enterprise 4.15.x (Jan 2019) Sprint Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

3 participants