Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker - Issues with range picker, resetting the old values. #1197

Closed
tmcconechy opened this issue Nov 9, 2018 · 8 comments · Fixed by #1219
Closed

Datepicker - Issues with range picker, resetting the old values. #1197

tmcconechy opened this issue Nov 9, 2018 · 8 comments · Fixed by #1219
Assignees
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Nov 9, 2018

Describe the bug
There are some issues with date picker when using range picker.

To Reproduce
Bug One

  1. Go to http://localhost:4000/components/datepicker/example-range.html
  2. Click on the picker and select a range
  3. Go back in the field
  4. Clear the values
  5. Open again
  6. Error: The picker should not be showing the old value

Bug Two

  1. Go to http://localhost:4000/components/datepicker/example-range.html
  2. Click on the picker and select a range
  3. Go back in the field
  4. Type a value in the field
  5. Should not have to hit space in between in the mask
  6. Open again
  7. Error: The picker should not be showing the old value

Expected behavior
Should reflect the value in the field.

CC Lothar Blum

@tmcconechy tmcconechy added type: bug 🐛 [3] Velocity rating (Fibonacci) labels Nov 9, 2018
@tmcconechy tmcconechy changed the title Datepicker - Issues with range picker, restarting the old values. Datepicker - Issues with range picker, resetting the old values. Nov 9, 2018
@tmcconechy
Copy link
Member Author

Part is related to #415

@tmcconechy tmcconechy self-assigned this Nov 13, 2018
@clepore clepore added this to Ready For QA in Enterprise November Sprint Nov 13, 2018
@clepore clepore moved this from Ready For QA to In progress in Enterprise November Sprint Nov 13, 2018
@tmcconechy tmcconechy moved this from In progress to Ready For QA in Enterprise November Sprint Nov 16, 2018
@tmcconechy
Copy link
Member Author

Noting that issue on is fixed but issue 2 is open as a duplicate #415

@brianjuan
Copy link

http://localhost:4000/components/datepicker/example-range.html
Does the fix also apply to Date picker with disabled date? Currently, Bug 1 can still be encountered on "Range - Disable Not included" and "Range - Disable included"

@tmcconechy
Copy link
Member Author

tmcconechy commented Nov 26, 2018

Yes it should, im trying again and not seeing any problem with those. It does not seem to be reverting to the old value. Can you test on http://4130-beta0-enterprise.demo.design.infor.com/components/datepicker/example-range.html instead of localhost to be sure your on the right code?

But i do see the new case here #1268 which is much more minor.

@brianjuan
Copy link

Hi @tmcconechy , I also tried http://4130-beta0-enterprise.demo.design.infor.com/components/datepicker/example-range.html and I can still encounter the bug on "Range - Disable Not included" and "Range - Disable included". And also on "Range - Initial value by Settings"
datepicker_oldval3

@tmcconechy
Copy link
Member Author

OK i see on the clear. Can we make a new ticket for this last part then.

@brianjuan
Copy link

Created new ticket #1306

@tmcconechy tmcconechy moved this from Ready For QA (beta release) to Ready for QA (rc release) in Enterprise November Sprint Nov 29, 2018
@brianjuan
Copy link

https://4130-rc0-enterprise.demo.design.infor.com/components/datepicker/example-range.html
Bug 1 and Bug 2 are now fixed, tested on all browsers. Moving to this Done.

@brianjuan brianjuan moved this from Ready for QA (rc release) to Done in Enterprise November Sprint Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants