Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style of read-only Text Input field has changed in Light Theme #1055

Closed
sanx72 opened this issue Oct 23, 2018 · 3 comments
Closed

Style of read-only Text Input field has changed in Light Theme #1055

sanx72 opened this issue Oct 23, 2018 · 3 comments
Assignees
Labels
type: regression bug ↩️ [1] Velocity rating (Fibonacci)

Comments

@sanx72
Copy link

sanx72 commented Oct 23, 2018

Describe the bug
Between version 4.8 and 4.9, the text colour used within read-only text fields has changed, but only in the Light Theme. To compare...

To Reproduce
https://design.infor.com/code/ids-enterprise/4.8.0/demo/input/example-index?font=source-sans
https://design.infor.com/code/ids-enterprise/4.9.0/demo/input/example-index?font=source-sans

I can see nothing in the release notes that implies this is deliberate and the new style essentially makes the read-only text look disabled, and definitely much more difficult to read. We use this style extensively in our Infor ERP applications, and the new style has effectively made the fields unusable in the default theme, and is therefore preventing us upgrading to the latest release of SoHo Xi to take other fixes we need.

Expected behavior
Can we have a fix, or, if this style change is deliberate, then can we have a alternate read-only class to go back to the original styling?

Screenshots
n/a

Platform
Reproduced using MS Windows 8.1, with Chrome, FireFox and IE11 (latest versions of all browsers).

@tmcconechy tmcconechy added type: regression bug ↩️ [1] Velocity rating (Fibonacci) labels Oct 23, 2018
@tmcconechy
Copy link
Member

Yes, your right it used to be https://design.infor.com/code/ids-enterprise/4.7.0/demo/input/example-index?font=source-sans i think due to token changes? @jmacaluso711 @clepore ?

@clepore
Copy link
Contributor

clepore commented Oct 23, 2018

@tmcconechy Yeah it was an unexpected changed. I did a manual fix and the tokens will resonate this in their next release.

@sanx72 This will go out when we release v4.12.0 in a week or so 👍

@clepore clepore closed this as completed Oct 25, 2018
@brianjuan
Copy link

http://4120-rc2-enterprise.demo.design.infor.com/components/input/example-index
Passed QA testing on all browsers, read-only is now back to its original styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression bug ↩️ [1] Velocity rating (Fibonacci)
Projects
None yet
Development

No branches or pull requests

4 participants