Userscript (Fixes #564) #565
Conversation
|
General comment: please follow the dev guidelines: https://github.com/infokiller/web-search-navigator#coding-style |
| OPTIONS_JS=$(cat "$PTH/options.js" | base64) | ||
| BROWSER_POLYFILL_JS=$(cat "$PTH/userscript-polyfill.js" "$PTH/browser-polyfill.js" | base64) | ||
|
|
||
| FINAL=$(echo "${USERSCRIPT_OPTIONS//__OPTIONS_HTML__/$OPTIONS_HTML}") |
There was a problem hiding this comment.
No need to use echo here and below
| @@ -0,0 +1,46 @@ | |||
| mkdir -p build/userscript | |||
There was a problem hiding this comment.
Add a proper shebang line (look at other files and follow their style)
| @@ -0,0 +1,34 @@ | |||
| globalThis.IS_USERSCRIPT = true; | |||
|
|
|||
| globalThis._localStorage_browser_polyfill = { | |||
There was a problem hiding this comment.
_browser_userscript_polyfill and _localStorage_browser_polyfill have inconsistent names (camel case mixed in, different order).
| } | ||
|
|
||
| save() { | ||
| localStorage.setItem(STORAGE_KEY, JSON.stringify(this.values)); |
There was a problem hiding this comment.
Where is localStorage defined? Is it from the userscript manager?
|
@infokiller Appreciate your review - Working on implementing an options page, will use GM_setValue and GM_getValue in userscript environments, then I'll rewrite commit msgs. Might not get a chance for a few weeks though. |
|
@Explosion-Scratch no worries, and I also don't expect changes that will make it hard to merge your fork in the near future. |
Fixes #564