[Bug]: Pressing Enter on "More results" in Google loads a page without "More results"

[CyberShadow]

Related issues

• I have searched the existing issues

What happened?

When I'm logged in to Google, I get a SRP with a "More results" button at the bottom.

When I navigate to it (with j/k) and press space/enter to activate it, it does load the second page of results. However, that second page does not have a "More results" button, leaving no way to load the third page of the results.

2023-07-18.05.09.17.mp4

Browsers

Chrome, Firefox

Other extensions

Yes

Version

0.5.2

Troubleshooting result

• I have followed the troubleshooting section

Anything else

I could not follow the troubleshooting section.

The following happens:

Applying config file: ./package.json
Running web extension from /home/vladimir/tmp/2023-07-18d/web-search-navigator/src

Error: connect ECONNREFUSED 127.0.0.1:46411
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1278:16)

Error code: ECONNREFUSED

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

However, I did reproduce the problem in a clean Chromium and Firefox profile (using the version from the corresponding browser's extension store).

[infokiller]

Hi @CyberShadow and thanks for the great bug report!
I was enable to reproduce it and will try to fix it when I have some free time
I'll also try to reproduce the troubleshooting issue later

[CyberShadow]

Thank you kindly for the quick response. Regarding the troubleshooting issue, it's probably something messed up with my system, so don't worry too much about it.

[infokiller]

From a quick look, the issue seems to be that the "More results" button is an anchor element (<a>) and the URL points to this strange page where you have no way to navigate further. The current logic we use for navigating is to use the href if it's an <a>, and only click otherwise, hence why it happens:

https://github.com/infokiller/web-search-navigator/blob/master/src/main.js#L533C1-L539C8

It should be easy to fix this by also checking for role=button, though I'll have to check it won't break anything else.

[infokiller]

BTW @CyberShadow, I have a completely unrelated question.

Background: I'm a happy user of aconfmgr for 5+ years, so many thanks for creating that project. It's the only tool I found for easy management of my Archlinux system config, and it's what kept from switching to NixOS/Guix.

Now to my question: I spotted Nix in your screencast above and was wondering if you've switched to NixOS, and if so, would you recommend it?

Thanks!

[CyberShadow]

Sure!

I'm still using Arch Linux (and aconfmgr) :)

I started looking at Nix because it allows creating reproducible containers, something which is not really possible with Alpine or Debian-based distributions. It is actually also sort-of possible with Arch Linux, if you use the Arch Linux Archive and set Server=https://archive.archlinux.org/repos/some-date-here, and disable package signature checking... but it's not really intended to be used that way and not as flexible.

I have not tried NixOS as an Arch replacement, so I can't comment on that. However I can recommend at least looking at Nix itself if free time allows; the language (being purely functional and lazily evaluated) is sometimes a little mind-bending, but some of the offered features like reproducible containers or scripts are pretty cool and a good tool to have.

[infokiller]

Thanks for the helpful response, and I'm glad you're still using aconfmgr :)