Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Type Hints #622

Closed
hf-kklein opened this issue Dec 18, 2023 · 2 comments · Fixed by #654
Closed

Missing Type Hints #622

hf-kklein opened this issue Dec 18, 2023 · 2 comments · Fixed by #654
Assignees
Milestone

Comments

@hf-kklein
Copy link
Contributor

Proposal:

  • There should be type hints in this library.
  • The type hints shall be available to users of the library.

Current behavior:

  • There are no type hints.
  • When type checking my own code with mypy, I get the error message:

error: Skipping analyzing "influxdb_client": module is installed, but missing library stubs or py.typed marker [import-untyped]

Desired behavior:

  • There shall be type hints in the code, especially in the user facing signatures.
  • there shall be a py.typed file that is contained in the package (see PEP 561).

Alternatives considered:
None that I know of.

Use case:

  • Better developer experience
  • Type checks in code using this client (aka "Compile" time safety)
@bednar
Copy link
Contributor

bednar commented Jan 8, 2024

Hi @hf-kklein,

thanks for your suggestion.

Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.

Regards

@bednar
Copy link
Contributor

bednar commented May 13, 2024

@alespour it is already resolved in v3 client

@alespour alespour mentioned this issue May 13, 2024
5 tasks
@bednar bednar added this to the 1.43.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants