Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate changes to react-router v5-branch #1614

Open
jhsware opened this issue Nov 6, 2022 · 4 comments
Open

Investigate changes to react-router v5-branch #1614

jhsware opened this issue Nov 6, 2022 · 4 comments

Comments

@jhsware
Copy link
Contributor

jhsware commented Nov 6, 2022

The v5 branch of react-router has been updated after the initial inferno-router port. These should be ported to inferno-router to keep it compatible with the docs. Also, these are probably useful features.

Go through the list of commits and check which ones add functionality that are relevant to inferno-router:

https://github.com/remix-run/react-router/commits/v5

NOTE: A lot of the commits are just maintenance of the project or docs so I don't think it will be too much work.

@ScottAwesome
Copy link

wouldn't it be useful to move to V6? They also introduce alot of new functionality that I think inferno users would benefit from

@jhsware
Copy link
Contributor Author

jhsware commented Feb 2, 2023

react-router v6 relies on hooks and the context api, so I would imagine that it requires a lot of work to port it.

Are there any specific features that you believe would be game changers compared to v5?

@ScottAwesome
Copy link

ScottAwesome commented Feb 3, 2023

react-router v6 relies on hooks and the context api, so I would imagine that it requires a lot of work to port it.

Are there any specific features that you believe would be game changers compared to v5?

The new loaders pattern would be powerful and nested routes. They allow you to run asynchronous work when navigating to the route and the resolved data is passed in to the component.

The new forms pattern is a big improvement too

@jhsware
Copy link
Contributor Author

jhsware commented Feb 3, 2023

I have an implementation of loader in PR #1621 but not done the forms part. You can check it out and see what you think.

I added hooks-like helper methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants