Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge fixtures for test cases in inferno-server #1502

Open
jhsware opened this issue Jan 28, 2020 · 1 comment
Open

Merge fixtures for test cases in inferno-server #1502

jhsware opened this issue Jan 28, 2020 · 1 comment
Labels
enhancement maintenance / build tools

Comments

@jhsware
Copy link
Contributor

jhsware commented Jan 28, 2020 •
edited

The following test files have a lot of overlap, but also some minor differences. Wouldn't it be better to have a common file so they can share const testEntries?

inferno/packages/inferno-server/__tests__/creation-queuestream.spec.server.jsx

Line 65 in 888b0c7

const testEntries = [

inferno/packages/inferno-server/__tests__/creation-stream.spec.server.jsx

Line 19 in 888b0c7

const testEntries = [

inferno/packages/inferno-server/__tests__/creation.spec.server.jsx

Line 12 in 888b0c7

const testEntries = [

@jhsware jhsware changed the title Merge ts Merge fixtures for test cases in inferno-server Jan 28, 2020
@Havunen
Copy link
Member

Havunen commented Jan 28, 2020

Yeah, could be merged

This was referenced Jan 28, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement maintenance / build tools
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Havunen @jhsware