Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized TO & END replaced with English in Library #113

Open
slodki opened this issue Mar 19, 2019 · 1 comment
Open

Localized TO & END replaced with English in Library #113

slodki opened this issue Mar 19, 2019 · 1 comment

Comments

@slodki
Copy link
Contributor

slodki commented Mar 19, 2019

  1. Enter following code using localized Logo procedures/keywords (example in Polish Logo):
    oto gwiazda
      powtórz 5 [ np 100 pw 144 ]
    już
    gwiazda
    
  2. Run above code - star is displayed
  3. Check History panel - verbatim copy of above code is displayed
  4. Check Library panel - following code is displayed:
    TO gwiazda
      powtórz 5 [ np 100 pw 144 ]
    END
    
    oto replaced with TO and już replaced with END. Localized and English commands are mixed together.

Original localized procedures are stored in Library except TO and END words hardcoded in LogoInterpreter.definition():

jslogo/logo.js

Line 1182 in 8d56a62

var def = "to " + name;

jslogo/logo.js

Line 1197 in 8d56a62

def += "\n" + "end";

@inexorabletash
Copy link
Owner

Yeah... and with the localization scheme just being aliases (for TO at least) there's no good way to select the appropriate version.

It's probably easiest to stash the whole original input line somewhere and use that instead. PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants