Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding videos #7

Open
HeidiSeibold opened this issue May 27, 2020 · 1 comment
Open

Embedding videos #7

HeidiSeibold opened this issue May 27, 2020 · 1 comment

Comments

@HeidiSeibold
Copy link

Hi @ines!

Thanks for your great work and the course templates! 馃憦

I saw that in your spaCy course you now also have videos. Are you planning to put those in the templates as well?

If you could hint me to the files/relevant lines I could give it a try myself and create a PR.

@ines
Copy link
Owner

ines commented Jun 11, 2020

Thanks and sorry for the late reply! The relevant code is pretty much all here: https://github.com/ines/spacy-course/blob/master/src/components/slides.js Here's the summary of the changes I made to spacy-course: explosion/spacy-course@7823361

Most of the heavy lifting is done by the plyr library. I've also added some custom logic to allow setting a custom start and end timestamp for the video, so you can use one single video (e.g. on YouTube) and reference that across the chapters 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants