New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No error thrown when there is garbage data past end-of-frame #181
Comments
Ignoring junk data after a valid zstd frame is intended for the But this report is for the I agree the one-shot API should probably reject garbage past end-of-frame. The API docs even say this:
So I consider this a bug. Hyrum's Law says someone is likely relying on the buggy behavior. So we may want to provide an argument to maintain the existing behavior, just in case. |
On 0.17.0, the following example doesn't throw an error:
Perhaps debatable, but I think an error should always be thrown if there is data past the last valid frame in a stream. Especially after fixing #59, I don't think it makes sense to silently ignore the garbage past end-of-frame. Users should be notified if they are constructing invalid streams.
Thanks @thatch for identifying this issue.
The text was updated successfully, but these errors were encountered: