Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit full screen mode in Yosemite #180

Open
TomLiu opened this issue Jul 27, 2014 · 7 comments
Open

Exit full screen mode in Yosemite #180

TomLiu opened this issue Jul 27, 2014 · 7 comments

Comments

@TomLiu
Copy link

TomLiu commented Jul 27, 2014

In Yosemite click the green traffic light can enter and exit full screen mode. INAppStoreWindow didn't show traffic light under full screen mode, users can't exit like other apps by clicking the green traffic light.

@TomLiu TomLiu changed the title exit full screen mode in Yosemite Exit full screen mode in Yosemite Jul 27, 2014
@mz2
Copy link

mz2 commented Sep 4, 2014

I've hit the same issue too. Any ideas about a fix or a workaround?

@martinjbaker
Copy link
Contributor

I don't. I only use INAppStoreWindow for the ability to change title bar colour, so I'm probably going to abandon it and move to a textured window with custom content view.

@Kapeli
Copy link
Contributor

Kapeli commented Sep 4, 2014

I was able to fix this issue and get the buttons to show for me by disabling these 3 lines in Yosemite:

close.frame = closeFrame;
minimize.frame = minimizeFrame;
zoom.frame = zoomFrame;
.

As far as I can tell, the issue is caused by INAppStoreWindow trying to change the frame of the buttons (even if you didn't customise anything related to the window buttons). Disabling the change of frame of docIconButton might also be needed for document-based apps, not sure.

Unfortunately I don't have the time to look into this further and fix it properly (i.e. find a way to get the buttons to actually change frame reliably so they can be customised), so I can't submit a pull request.

@mz2
Copy link

mz2 commented Sep 4, 2014

I can confirm that your workaround works on Yosemite. I've put our version of the workaround here:
mekentosj@23e06df

This needs some further work still -- the traffic light buttons don't center again after coming back from fullscreen with this workaround in place (they do center again after the window is resized after that).

@ingon
Copy link

ingon commented Oct 20, 2014

Maybe this could be the answer: #192

@ingon
Copy link

ingon commented Nov 12, 2014

@indragiek & @jakepetroules this seems to affect a lot of people, do you guys think we can get this fixed/merged?

@cparnot
Copy link

cparnot commented May 7, 2015

I have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants