Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy corners when using darker colors #146

Open
jwells89 opened this issue Feb 15, 2014 · 5 comments
Open

Fuzzy corners when using darker colors #146

jwells89 opened this issue Feb 15, 2014 · 5 comments

Comments

@jwells89
Copy link

Because of how INAppStoreWindow draws itself on top of the native titlebar, a few pixels of lighter-colored “fuzz” become visible when you use the custom drawing block and darker colors. This isn’t apparent when using the built-in drawing methods because it’s covered up by the default highlight.

screen shot 2014-02-15 at 12 43 42 pm

The only way I’ve found around this is to generate your own path with a smaller corner radius and draw using this instead of the provided clippingPath, but that’s not ideal for a number of reasons.

@indragiek
Copy link
Owner

Are you experiencing the same issue as #111? That one hasn't been fixed yet, unfortunately. But if it's the same one then this can be closed to avoid having duplicate issues open.

@MattTimmons
Copy link

I am not certain if this is the same. @jwells89 , could you post how you did your re-draw?
Here is what I get when using a darker color in the drawBlock.
screen shot 2014-09-06 at 4 35 40 pm

@MattTimmons
Copy link

Hi, how has others solved this? I have been playing around a lot this morning, but I can not find a way to override the "background" default window tool bar which keeps showing through. HipChat for OS X had a very nice title bar, I wonder if they are using this library?
screen shot 2015-01-02 at 10 17 17 am

@indragiek
Copy link
Owner

@MattTimmons I believe I ran into this a while ago and solved it by layer backing the theme frame. That is:

[[[window contentView] superview] setWantsLayer:YES];

@MattTimmons
Copy link

hm. I did not think of that.. I did a few things to get by.

  1. Used setTitleBarGradient instead of the drawingBlock.
  2. INAppStoreWindow.m border radius to 5.0f
  3. INAppStoreWindow.m add 1px to the high… drawingRect.size.height += window.toolbarHeight+1;

On Jan 2, 2015, at 1:55 PM, Indragie Karunaratne notifications@github.com wrote:

@MattTimmons https://github.com/MattTimmons I believe I ran into this a while ago and solved it by layer backing the theme frame. That is:

[[[window contentView] superview] setWantsLayer:YES];

Reply to this email directly or view it on GitHub #146 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants