Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic light buttons and fullscreen button restore original position after starting to edit on Document apps #137

Open
djui opened this issue Jan 11, 2014 · 5 comments

Comments

@djui
Copy link

djui commented Jan 11, 2014

When using and Document app and using titleBarDrawingBlock the traffic light buttons and the fullscreen button restore their original position (move to the top) when having a custom titlebar height and starting the edit the document (i.e. when the "- Edited" additonal text appears).

I assume a redraw could be a workaround, butI don't know when and where.

@indragiek
Copy link
Owner

The fix is already implemented. Just add NSDocument+INAppStoreWindowFixes to your project from the Extensions folder.

@djui
Copy link
Author

djui commented Jan 11, 2014

Thanks!

Would be nice to see this somewhere described in the README? Furthermore, When using cocoapods, the extension folder is not locally available.

@indragiek
Copy link
Owner

Good idea 👍 I'm not sure what to do about the CocoaPods issue, I don't think it should be included by default because it swizzles stuff.

@djui
Copy link
Author

djui commented Jan 11, 2014

Just tried the fix, but it is incomplete:

  1. The icon is not always aligned on the first go (e.g. I create a new document, no icon there yet, when saving, the icon exists, but is not aligned correctly).
  2. There is a short but noticable redraw glitch every time the document changes and "- edit" is shown.
  3. The document title text is aligned correctly, but is cut off on the lower end (e.g. for "g", "y", "p", ...)
  4. The realignment happens sometimes seconds later.

So, I guess it's hard to get it right for Document title bars...

@indragiek
Copy link
Owner

Ok, reopening this issue until we can get this fully sorted out :)

@indragiek indragiek reopened this Jan 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants