Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Use std's OnceLock instead of once_cell #312

Closed
wants to merge 2 commits into from

Conversation

mks-h
Copy link

@mks-h mks-h commented Feb 25, 2024

While this removes once_cell from dependencies, it is still being used
as an indirect dependency due to "internment" crate.

Note that I had to do the same change as in #305 to make the project compile.

Resolves #292

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

While this removes once_cell from dependencies, it is still being used
as an indirect dependency due to "internment" crate.
@mks-h
Copy link
Author

mks-h commented Feb 25, 2024

I don't wish to sign the license. Please close the PR if that's a problem.

@mks-h mks-h marked this pull request as ready for review February 25, 2024 02:00
@mks-h mks-h changed the title lib/utils: Replace once_cell with std's OnceLock lib: Use std's OnceLock instead of once_cell Feb 25, 2024
@ysimonson
Copy link
Member

Sounds good, closing out

@ysimonson ysimonson closed this Feb 25, 2024
@mks-h mks-h deleted the std-once-cell branch February 25, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to std variant of once_cell
3 participants