Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling set_edge_properties doesn't return error if edge doesn't exist #192

Open
ozgrakkurt opened this issue Oct 30, 2021 · 4 comments
Open

Calling set_edge_properties doesn't return error if edge doesn't exist #192

ozgrakkurt opened this issue Oct 30, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ozgrakkurt
Copy link
Contributor

There doesn't seem to be any way to know this operation succeeded. Is this really the case?
@ozgrakkurt
Copy link
Contributor Author

ozgrakkurt commented Oct 30, 2021 •
edited

So I looked into the code and it seems like It would be easy to convert the api to Result<u64> where the number indicates how many properties were changed. I think this would be useful. Should I do a pr about this maybe?

@ysimonson
Copy link
Member

Yeah that change makes sense. I don’t know offhand if the various datastore implementations would support returning a count though.

@ozgrakkurt
Copy link
Contributor Author

Working on doing this. I couldn't make much progress because of work but I should have a PR soon.

@ozgrakkurt ozgrakkurt mentioned this issue Nov 7, 2021
Closed
@ysimonson ysimonson added enhancement New feature or request help wanted Extra attention is needed labels Feb 10, 2022
@ysimonson
Copy link
Member

@ozgrakkurt I'm going to unassign for now, but if you circle back to this please do let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Update Transaction trait and implementations to return counts
2 participants
@ysimonson @ozgrakkurt