Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace firingUnixTimestampSeconds with duration field #372

Open
longquanzheng opened this issue Feb 27, 2024 · 1 comment
Open

Replace firingUnixTimestampSeconds with duration field #372

longquanzheng opened this issue Feb 27, 2024 · 1 comment

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Feb 27, 2024

  1. more accurate to use relative time
  2. easier for unit test
  3. cleaner and easier to read the history events
@longquanzheng
Copy link
Contributor Author

longquanzheng commented May 20, 2024

#388 NOTE: This will need more work than this PR due to continueAsNew -- the duration value cannot be used in next run, because after continueAsNew, the workflow.now() has changed. We have to also write down the start time, or convert it to firingUnixTimestamp when the timer started, in order to pass to next run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant