Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title screen author overwrites title if title is 3 lines or over #986

Open
david-pfx opened this issue Feb 23, 2024 · 4 comments
Open

Title screen author overwrites title if title is 3 lines or over #986

david-pfx opened this issue Feb 23, 2024 · 4 comments

Comments

@david-pfx
Copy link

To reproduce:

title Simple Block Pushing Game title Simple Block Pushing Game title Simple Block Pushing Gametitle Simple Block Pushing Gametitle Simple Block Pushing Gametitle Simple Block Pushing Game
author David Skinner author David Skinner author David Skinner author David Skinner author David Skinner author David Skinner author David Skinner author David Skinner author David Skinner
homepage www.puzzlescript.net

@increpare
Copy link
Owner

There are warning messages generated for your example example saying that both the title and author name have been truncated. What behaviour do you expect?

@david-pfx
Copy link
Author

For this example I would expect to see 3 lines of title, 3 lines of author, then the continue/new game prompt.

@increpare
Copy link
Owner

I think there are three levels of possible actions:

First level:
There is a slightly buggy behaviour in that the message that says

line 1 : Game title is too long to fit on screen, truncating to three lines.

really should be issuing a warning after two lines.

Second level:
fiddling around with the effective five lines of current space to fit in both author and title (moving the author down to accommodate more lines if needed, to a maximum of four lines for title + one for authoer)

Third level:
Dynamically adjusting the resolution to fit all given text might be the more graceful behaviour. I'm slightly wary about this - I don't want to go out of my way to enable people to give their games extravagantly long names.

Not closing, but low priority. People know what they are doing when they give their games long titles, and they can immediately see the effect of doing so.

@david-pfx
Copy link
Author

I agree. I think I would just reduce the 3 and 5 to 2 and 4.

BTW I found this mostly because PS+ has a much worse version when mouse is active: hover triggers multiple warnings. That one is much harder to fix. Triggering compile errors in the engine is not really a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants