-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node build fails with 'illegal characters in path' #955
Comments
This is caused by a breaking change in rimraf version 4. See: isaacs/rimraf#251. On Linux/MacOS, the glob path is a valid path so just doesn't delete any images. Need to pin rimraf to version 3. We should commit |
I agree 100%. Working on it (if I ever get the sodding thing to work😣) |
Problem solved. I'll submit a PR. |
Illegal characters in file name or script are replaced by "!", and a warning emitted.
Illegal characters in file name or script are replaced by "!", and a warning emitted.
Single purpose PR submitted. |
Here is the node install and command line:
npm i rimraf compress-images web-resource-inliner ncp gifsicle@5.3.0 concat ycssmin terser gzipper html-minifier-terser glob
node compile.js
Here is the full error trace:
Debugging shows that the illegal character is the '*'. My guess is it should be globbed, but isn't. Beyond that I have no idea.
The text was updated successfully, but these errors were encountered: