Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are flagged for malware #354

Open
greenseeker opened this issue Feb 28, 2023 · 3 comments
Open

Windows builds are flagged for malware #354

greenseeker opened this issue Feb 28, 2023 · 3 comments
Labels
automation Build, test, CI/CD automation quality

Comments

@greenseeker
Copy link

greenseeker commented Feb 28, 2023

This was first flagged by my company's security team. When I checked it at virustotal.com, the latest 3.1.0 beta is flagged with Trojan.PSW.Disco.frp and Trojan.Malware.300983.susgen:

https://www.virustotal.com/gui/file/9cbf8a7bc63935a5f7f74480eb3fd72610a12b469677003c5fc9a0f268d36f5a?nocache=1

The 3.1.0 Linux build comes up clean. Are these false positives?

Older builds have similar results.

@jhillyerd
Copy link
Collaborator

jhillyerd commented Feb 28, 2023

All of the builds are done via a single github action, not from my personal machine, so I think the likelihood that it's a false positive is high. The builds leverage a 3rd party build & packaging tool: goreleaser

Release build config lives here, this triggers goreleaser:
https://github.com/inbucket/inbucket/blob/main/.github/workflows/release.yml

Goreleaser config lives here:
https://github.com/inbucket/inbucket/blob/main/.goreleaser.yml

Build output from the recent beta: https://github.com/inbucket/inbucket/actions/runs/4296529322/jobs/7488362079

Virustotal doesn't make it clear what file is triggering the warning, although I would expect one of the EXEs, as the compiled UI assets would be the same in the Linux release.

If we can narrow it down to a particular file, we could try building that outside of github and see if it still triggers.

Edit: I should note that the Inbucket program does not try to phone home, or do any analytics/telemetry collection.

@jhillyerd jhillyerd added quality automation Build, test, CI/CD automation labels Feb 28, 2023
@jhillyerd
Copy link
Collaborator

Sounds like this may be common with binaries produced by Go:

lian/msfs2020-go#14

https://go.dev/doc/faq#virus

@greenseeker
Copy link
Author

Virustotal doesn't make it clear what file is triggering the warning, although I would expect one of the EXEs, as the compiled UI assets would be the same in the Linux release.

If we can narrow it down to a particular file, we could try building that outside of github and see if it still triggers.

It's inbucket-client.exe, though I expect the Go links are probably correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Build, test, CI/CD automation quality
Projects
None yet
Development

No branches or pull requests

2 participants