Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong css code in customizer-editor.post.css #170

Open
daprela opened this issue Mar 17, 2016 · 4 comments
Open

Wrong css code in customizer-editor.post.css #170

daprela opened this issue Mar 17, 2016 · 4 comments
Assignees

Comments

@daprela
Copy link
Contributor

daprela commented Mar 17, 2016

The file customizer-editor.post.css contains nested selectors. This is a common practice in SASS and LESS but not admitted in the final version that the browser reads.

The whole file need to be reviewed and fixed


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@daprela daprela self-assigned this Mar 17, 2016
@DavidWells
Copy link
Member

Look at the gulp file. It will build the CSS the browser needs

I believe the terminal command is gulp css-watch

It's using postCSS to build.

The nested selectors are ensuring that the styles won't be broken by other themes or plugins

  • David Wells

On Mar 17, 2016, at 9:40 AM, Giulio notifications@github.com wrote:

The file customizer-editor.post.css contains nested selectors. This is a common practice in SASS and LESS but not admitted in the final version that the browser reads.

The whole file need to be reviewed and fixed


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@daprela
Copy link
Contributor Author

daprela commented Mar 17, 2016

Thanks for the info.
Besides that, I'll probably need to move this issue in cta because the file is in the shared folder

@atwellpub
Copy link
Member

@DavidWells

David are you saying that the customizer-editor.post.css is develeped inside nests and the gulp is used to parse the nesting and created customizer-editor.css?

@DavidWells
Copy link
Member

Yes. The gulp task writes the browser readable CSS

On Mar 17, 2016, at 4:26 PM, Hudson Atwell notifications@github.com wrote:

@DavidWells

David are you saying that the customizer-editor.post.css is develeped inside nests and the gulp is used to parse the nesting and created customizer-editor.css?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants