Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbound Forms - Question #133

Open
atwellpub opened this issue Aug 20, 2015 · 6 comments
Open

Inbound Forms - Question #133

atwellpub opened this issue Aug 20, 2015 · 6 comments
Labels

Comments

@atwellpub
Copy link
Member

atwellpub commented Aug 20, 2015

User is having trouble with this file not being available in his cloud hosted environment. Is there an alternative to loading this file directly?

https://github.com/inboundnow/leads/blob/master/shared/shortcodes/shortcodes-fields.php#L9-L11

See support request:
http://support.inboundnow.com/support/topic/fatal-error-on-subfolder-install-of-wp/page/2/


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@DavidWells
Copy link
Member

Shortcodes is one of those tricky bits of the software.

In reality we need to start systematically removing all of them minus the
ones that drive forms and port them to their own add-on that we will
eventually retire.

The shortcode setup was forked from another theme long ago.

I don't think it needs to be included this way but I'm not sure how to fix
it. I will have a look

Do you have any ideas?

On Thu, Aug 20, 2015 at 12:14 PM, Hudson Atwell notifications@github.com
wrote:

Assigned #133 #133 to
@DavidWells https://github.com/DavidWells.


Reply to this email directly or view it on GitHub
#133 (comment).

@atwellpub
Copy link
Member Author

Why exactly does it need to load it's own wp-load.php? Maybe we can find a way to hook all that into an init and then load an wp-admin url that opens the shortcode page rather than the shortcode page directly?

@DavidWells
Copy link
Member

Honestly not sure. Remove it and see what explodes =P

I can't see any wordpress core specific stuff in that file below

On Thu, Aug 20, 2015 at 1:02 PM, Hudson Atwell notifications@github.com
wrote:

Why exactly does it need to load it's own wp-load.php? Maybe we can find a
way to hook all that into an init and then load an wp-admin url that opens
the shortcode page rather than the shortcode page directly?


Reply to this email directly or view it on GitHub
#133 (comment).

@DavidWells
Copy link
Member

I think it had to to will all the shortcodes
in /shared/shortcodes/shortcodes folder. I think some of them use wordpress
functions but they are global variables and not in the wordpress context

On Thu, Aug 20, 2015 at 1:04 PM, David Wells david@inboundnow.com wrote:

Honestly not sure. Remove it and see what explodes =P

I can't see any wordpress core specific stuff in that file below

On Thu, Aug 20, 2015 at 1:02 PM, Hudson Atwell notifications@github.com
wrote:

Why exactly does it need to load it's own wp-load.php? Maybe we can find
a way to hook all that into an init and then load an wp-admin url that
opens the shortcode page rather than the shortcode page directly?


Reply to this email directly or view it on GitHub
#133 (comment).

@atwellpub
Copy link
Member Author

Everything but here seems ok:
http://screencast.com/t/qpbDKtYpVZ7

I'll take a crack at it.

@DavidWells
Copy link
Member

Form shortcode and
https://github.com/inboundnow/leads/blob/master/shared/shortcodes/shortcodes-fields.php#L15
need to roll out of there but the setup is super flimsy right now

I'm afraid if we move, the form builder will break.

On Thu, Aug 20, 2015 at 1:08 PM, Hudson Atwell notifications@github.com
wrote:

Everything but here:
http://screencast.com/t/qpbDKtYpVZ7

I'll take a crack at it.


Reply to this email directly or view it on GitHub
#133 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants