Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a fork of react-native-image-picker #569

Closed
3 of 5 tasks
kueda opened this issue Apr 12, 2023 · 0 comments
Closed
3 of 5 tasks

Try a fork of react-native-image-picker #569

kueda opened this issue Apr 12, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kueda
Copy link
Member

kueda commented Apr 12, 2023

Kind of a subtask of #431 and based on @Chrischuck's findings in #509, we need to explore maintaining a fork of https://github.com/react-native-image-picker/react-native-image-picker to support native image pickers and our own EXIF parser. Long story short, react-native-image-picker does a good job launching native image pickers in iOS and Android but it does not provide us with a path to the original URL of the photo that we need to extract all the EXIF data we want. There is a pull request in that repo that provides a path to the original URL in Android, but not in iOS.

Rough tasks here are

  • double check https://github.com/IceOfSummer/react-native-image-picker provides us with a path to an image with all the EXIF we need (lat, lon, horizontal accuracy)
  • Fork react-native-image-picker under the inaturalist account and pull in the IceOfSummer changes
  • Make a new branch of our fork and change the iOS implementation so it does the same thing, i.e. provides the path to an original image that can be used to extract all the EXIF we need
  • Maybe issue another pull request to react-native-image-picker for the iOS changes (hence the branch)
  • Merge the branch into our main and in theory that should allow Import photos using native photo chooser #431 to proceed using our fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants