Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review differences between master and develop #5106

Open
timlinux opened this issue Oct 14, 2021 · 3 comments
Open

Review differences between master and develop #5106

timlinux opened this issue Oct 14, 2021 · 3 comments
Assignees

Comments

@timlinux
Copy link
Contributor

I am trying to harmonise the master and develop branches. I am going to merge develop to master but there are a few differences which I have not resolved:

git diff origin/develop

patch-review.diff.txt

Please review the changes listed in the attached and see if any need to be merged into develop and master (I am going to force merge develop and master so they are matched)

@lucernae
Copy link
Collaborator

@timlinux Can I confirm the process?
So, should I commit the fix on master then pull it to develop or the other way around? (put the commit in develop then let master pull from develop).

@lucernae
Copy link
Collaborator

lucernae commented Oct 28, 2021

@timlinux I think the remaining conflicts were just diciding what the next version will be.
If I look at the GitHub release page, we have version 5.0.1.

In the metadata.txt in develop, our current version is 5.0.2, but it's not yet released in GitHub.
In the metadata.txt in master, our current version is 5.0.3, again not yet released in GitHub.

We just have to decide which one is the next version/release? Which one is correct, 5.0.3 or 5.0.4

@timlinux
Copy link
Contributor Author

@lucernae lets name it 5.0.3 since I released 5.0.2 for the last quick fix
image

Can you create a release for the version that I released (just link it to the 5.0.2 branch head)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants