Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that the package is packed correctly before publishing #50

Open
dnlup opened this issue Nov 25, 2021 · 5 comments
Open

Test that the package is packed correctly before publishing #50

dnlup opened this issue Nov 25, 2021 · 5 comments
Labels
github_actions Pull requests that update Github_actions code

Comments

@dnlup
Copy link
Contributor

dnlup commented Nov 25, 2021

No description provided.

@dnlup dnlup added the github_actions Pull requests that update Github_actions code label Nov 25, 2021
@simonecorsi
Copy link
Collaborator

What kind of problem are we trying to avoid?

@dnlup
Copy link
Contributor Author

dnlup commented Nov 29, 2021

That we could be forgetting to include a new file in the files field in the package.json 馃榿

@simonecorsi
Copy link
Collaborator

Ok but then you would have to remember to include new files in the script that checks for them, we could forget that too!

@dnlup
Copy link
Contributor Author

dnlup commented Nov 30, 2021

I was thinking using npm pack and then installing the package in a dummy project to see if it doesn't crash.

@simonecorsi
Copy link
Collaborator

I never had the need for this kind of check! If you think it may be useful I have no strong opinion about 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonecorsi @dnlup