Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventual crash on HoloLens from GamepadXRInputSource #153

Open
speigg opened this issue Nov 12, 2020 · 1 comment
Open

Eventual crash on HoloLens from GamepadXRInputSource #153

speigg opened this issue Nov 12, 2020 · 1 comment

Comments

@speigg
Copy link

speigg commented Nov 12, 2020

Runs fine for several minutes w/ hand tracking, until the following crash occurs:

Unable to get property '0' of undefined or null reference
TypeError: Unable to get property '0' of undefined or null reference
   at fromRotationTranslation (https://cdn.jsdelivr.net/npm/webxr-polyfill@latest/build/webxr-polyfill.js:301:3)
   at GamepadXRInputSource.prototype.updateBasePoseMatrix (https://cdn.jsdelivr.net/npm/webxr-polyfill@latest/build/webxr-polyfill.js:5541:7)
   at GamepadXRInputSource.prototype.getXRPose (https://cdn.jsdelivr.net/npm/webxr-polyfill@latest/build/webxr-polyfill.js:5548:5)
   at WebVRDevice.prototype.getInputPose (https://cdn.jsdelivr.net/npm/webxr-polyfill@latest/build/webxr-polyfill.js:5897:9)
   at XRFrame.prototype.getPose (https://cdn.jsdelivr.net/npm/webxr-polyfill@latest/build/webxr-polyfill.js:1295:7)
   at update (https://10.0.0.72:1234/index.4ca7163e.js:17013:11)
   at onAnimationFrame (https://10.0.0.72:1234/index.4ca7163e.js:17380:7)
   at onAnimationFrame (https://10.0.0.72:1234/index.4ca7163e.js:10529:5)
   at Anonymous function[PRIVATE$15].onDeviceFrame (https://cdn.jsdelivr.net/npm/webxr-polyfill@latest/build/webxr-polyfill.js:1465:7)

Note, I had to include a DOMPointReadOnly polyfill in order to run on HoloLens2 (as per #144)

@speigg
Copy link
Author

speigg commented Nov 12, 2020

The problem seems to be that GamepadXRInputSource.prototype.updateBasePoseMatrix() assumes that the gamepad's pose orientation will always be available when position is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant