Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are grip/targetRayTransform numbers in GamepadMappings correct? #138

Open
takahirox opened this issue Feb 7, 2020 · 1 comment
Open

Comments

@takahirox
Copy link
Contributor

takahirox commented Feb 7, 2020

Hi all.

Background

I'm making WebXR Emulator Extension which imports webxr-polyfill.js.

Problem

I tested Three.js XRControllerModelFactory with the extension. With the extension (webxr-polyfill.js) the controller (grip) or ray direction looks weird as the screenshots below.

On the emulated OculusGo of the extension the controller looks at different direction from the ray's while on real OculusGo the controller and ray seems to look at the same or similar direction.

Three.js XRControllerModelFactory + WebXR Emulator Extension + Emulated Oculus Go in VR mode
image

Three.js XRControllerModelFactory+ Real Oculus Go in VR mode
com oculus vrshell-20200207-234810_Moment

(FYI, Real Oculus Go out of browser. Looking different even a bit further from in VR mode??)
com oculus vrshell-20200207-215304

I haven't looked into other than OculusGo, but I think other devices may have the same issue.

my guess and question

I guess this issue may be from grip/targetRayTransform numbers defined in
GamepadMapping.

According to @jsantell, these numbers seems from this commit by @jacobcdewitt. So question, how are these numbers determined? And are these numbers looking correct?

@takahirox
Copy link
Contributor Author

takahirox commented Feb 7, 2020

I removed gripTransform from webxr-polyfill.js for OculusGo then the one emulated by the extension + polyfill looks closer to the real one.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant