fix motion events detection for iOS 13.4, which are broken #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to put in a vote for this, as this is a key component in getting aframe cardboard mode working again in iOS 13.4 (aframevr/aframe#4554) |
|
Is this fixed in Safari for versions after 13_4, if there are any? I don't have iOS devices to test, but I'll get this in |
|
Landed in de9678d in 1.0.19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix immersive-web/webxr-polyfill and basically any app out there which uses that webxr-polyfill (including the webxr-examples when apply the one another pre-grant permissions condition on iOS).
This fix is needed because devicemotion is broken in Safari for iOS 13.4, (as it was on Chrome m65).
So this PR adds the double condition to the actual
isWithoutDeviceMotionvariable.