Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch-v3 controller assets have rotation/position offset when using Quest + Link #202

Open
hybridherbst opened this issue Jan 3, 2022 · 4 comments
Labels
motion-controller motion-controller package

Comments

@hybridherbst
Copy link

hybridherbst commented Jan 3, 2022

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Attach Oculus Quest to desktop PC and enable Link
  2. Go to https://immersive-web.github.io/webxr-samples/input-profiles.html
  3. Click on "Enter VR"
  4. Place controller circle on a flat surface
  5. Observe position and rotation error in VR compared to real world
  6. Place controller circles against each other
  7. Observe position and rotation error in VR compared to real world

On Quest in the Oculus browser, orientation is correct; when you repeat the above on Quest with Link disabled you get a pretty perfect match between real world and virtual objects.

Expected behavior
Quest + Link controller model should match real-world orientation and position.

Screenshots
In VR via Quest + Link - note that there's not only a position but also a rotation offset (both are tilted outwards)
image

Oculus Home via Quest + Link controller orientation
image

Real-world orientation
1641223773341-01

Version
Latest used on https://immersive-web.github.io/webxr-samples/input-profiles.html

Desktop (please complete the following information):

  • OS: [Windows]
  • 3D engine: [all]
  • Browser [chrome]
@hybridherbst hybridherbst added the motion-controller motion-controller package label Jan 3, 2022
@Yonet
Copy link
Member

Yonet commented Jan 4, 2022

@cabanier do you know if this is an issue with Oculus controllers?

@cabanier
Copy link
Member

cabanier commented Jan 4, 2022

@Artyom17 and I have brought this up before as something that WebXR could address..
The controllers need an additional offset to be perfectly placed and we ended up hardcoding that in our code.

@cabanier
Copy link
Member

cabanier commented Jan 4, 2022

For reference, this is the issue.

@hybridherbst
Copy link
Author

Thanks for linking! Just to confirm that I get this right – the Oculus Browser on Quest applies custom offsets so that the controller models actually line up with the controllers? And the "better" fix would be that the offsets are fixed in this repo, and then the offset in Oculus Browser has to be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
motion-controller motion-controller package
Projects
None yet
Development

No branches or pull requests

3 participants