Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript profiles.d.ts definitions incorrect #173

Open
user-ops opened this issue Aug 7, 2020 · 1 comment
Open

Typescript profiles.d.ts definitions incorrect #173

user-ops opened this issue Aug 7, 2020 · 1 comment
Labels
motion-controller motion-controller package
Milestone
Next Release

Comments

@user-ops
Copy link

user-ops commented Aug 7, 2020 •
edited

The functions listed in profiles.d.ts are supposed to represent are async functions but the definitions do not match up.
Also it looks like fetchProfilesList key return should return a list profiles with a string property named path, instead it's just assuming the profile returns the string directly
@user-ops user-ops added the motion-controller motion-controller package label Aug 7, 2020
@Manishearth Manishearth added this to the Next Release milestone Aug 21, 2020
@nielsvanvelzen
Copy link

I've noticed this bug was fixed in #187 but no release has been made since. Is there any ETA for a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
motion-controller motion-controller package
Projects
None yet
Milestone
Next Release
Development

No branches or pull requests
3 participants
@Manishearth @nielsvanvelzen @user-ops