Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should add targetRaySpace offset in Profiles Registry? #164

Open
daoshengmu opened this issue Mar 13, 2020 · 0 comments
Open

Should add targetRaySpace offset in Profiles Registry? #164

daoshengmu opened this issue Mar 13, 2020 · 0 comments

Comments

@daoshengmu
Copy link
Contributor

daoshengmu commented Mar 13, 2020

When implementing targetRaySpace and gripSpace in XRInputSource, I notice Oculus and OpenVR only provide a pose matrix for both controllers. I assume the pose matrix means gripSpace for most of controllers. If so, there is no other information about targetRaySpace from the existing device APIs. In that case, if a browser engine doesn't hardcode to calculate offset values based on gripSpace to get targetRaySpace, that would not possible. Then, it will make UAs have different result for targetRaySpace in controllers, and it will cause Web compat issues.

I am thinking if it makes sense for profiles provide offset value to describe how position and orientation values of targetRaySpace in XRInputSource need to be changed. If this device API already has an API for getting targetRaySpace, the offset can be zero. On the other hand, we can make targetRaySpace has the same value with gripSpace in a browser engine. Then, using the offset value from profiles to transform the current targetRaySpace and give proper result to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant