Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking Wide Review for Level1 CR #50

Open
1 of 8 tasks
himorin opened this issue Jan 31, 2022 · 7 comments
Open
1 of 8 tasks

tracking Wide Review for Level1 CR #50

himorin opened this issue Jan 31, 2022 · 7 comments

Comments

@himorin
Copy link
Member Author

himorin commented Jan 31, 2022

/agenda Prepare for HR of WebXR gamepads module

@probot-label probot-label bot added the agenda label Jan 31, 2022
@Yonet Yonet removed the agenda label Feb 9, 2022
@toji
Copy link
Member

toji commented Feb 15, 2022

i18n self review brought up no issues. The functionality exposed by this API does not have any i18n impact as far as we are aware. It is worth noting that the "parent" APIs (Gamepad API and WebXR device API) do have some related functionality that might require I18n attention (such as gamepad IDs or input profiles), but that functionality should be reviewed as part of those APIs rather than this one.

@Yonet
Copy link
Member

Yonet commented Mar 9, 2022

/agenda Prepare for Horizontal Review(HR) of WebXR gamepads module

@probot-label probot-label bot added the agenda label Mar 9, 2022
@Yonet Yonet removed the agenda label May 3, 2022
@himorin
Copy link
Member Author

himorin commented May 20, 2022

@toji, even we don't have anything in i18n, I've filed an issue for short checklist as #54

@himorin
Copy link
Member Author

himorin commented May 20, 2022

self checklist completed. let me file HR issues, once @toji says 'go'.

@toji
Copy link
Member

toji commented May 20, 2022

Self review checklists all look good, thanks!

I guess this is the part where I say "Go!" 😄🚦

@himorin
Copy link
Member Author

himorin commented May 23, 2022

four HR requests filed! yay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants