Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Edit this page" button always visible #241

Open
jonasreiher opened this issue Jan 4, 2024 · 2 comments · May be fixed by #290
Open

Make "Edit this page" button always visible #241

jonasreiher opened this issue Jan 4, 2024 · 2 comments · May be fixed by #290
Labels
enhancement New feature or request
Milestone

Comments

@jonasreiher
Copy link

Feature Description

Ability to choose the location of the "Edit this page" link.

Problem/Solution

Currently, below the table of contents in the right side bar, an "Edit this page" button can be displayed. However, this button is not visible if the window is too narrow to display the TOC. Especially on mobile, there is no way to access the "Edit this page" button.

If the location of this button could be freely chosen (e.g. between right side bar, left side bar, navigation bar, bottom of page, ...) it could be configured such that it is always visible/can always be accessed.

Alternatives Considered

Building a custom shortcode to include this link. This would limit its location to the main page content.

Additional Context

Related discussion: #48

@jonasreiher
Copy link
Author

jonasreiher commented Jan 15, 2024

Could look like this on the bottom of the page:
Bildschirmfoto 2024-01-15 um 09 42 43

Or like this:
Bildschirmfoto 2024-01-15 um 10 25 19

@imfing imfing added the enhancement New feature or request label Jan 15, 2024
@imfing
Copy link
Owner

imfing commented Jan 15, 2024

Thanks for the suggestion.

I think the second image you posted makes a lot sense. We can make the location configurable.

@imfing imfing added this to the Backlog milestone Feb 6, 2024
@davlgd davlgd linked a pull request Feb 13, 2024 that will close this issue
@imfing imfing modified the milestones: Backlog, v0.8.0 Feb 20, 2024
@imfing imfing modified the milestones: v0.8.0, v0.9.0 Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants