Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate URI structure during signing. #95

Open
lilith opened this issue May 30, 2014 · 1 comment
Open

Validate URI structure during signing. #95

lilith opened this issue May 30, 2014 · 1 comment
Labels
enhancement
Milestone
V5

Comments

@lilith
Copy link
Member

lilith commented May 30, 2014

Better to fail early; RemoteReader should Uri.IsWellFormedUriString(requestEventArgs.RemoteUrl, UriKind.Absolute) during CreateSignedUrl.
@lilith lilith modified the milestone: V5 Dec 27, 2016
@edmacdonald
Copy link
Contributor

edmacdonald commented Jun 22, 2017 •
edited

The use of Uri.IsWellFormedUriString is causing an exception for Urls that may technically be invalid but are in use and supported by most, if not all, browsers. Here is an example from Volvo's site:

https://www.volvopartshop.com/ekmps/shops/tmsvolvo/images/v50-roof-rail-end-caps-black--front-or-rear-front-side-right-hand-18052-p[ekm]299x224[ekm].jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
V5
Development

No branches or pull requests
2 participants
@lilith @edmacdonald