Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebP support #256

Open
iJungleboy opened this issue May 25, 2020 · 4 comments
Open

Update WebP support #256

iJungleboy opened this issue May 25, 2020 · 4 comments

Comments

@iJungleboy
Copy link

iJungleboy commented May 25, 2020

There is an alpha/beta support for WebP but it uses a very old version of the libwebp library.

We would like to deploy WebP (inside 2sxc for DNN - a very popular plugin running on ca. 20'000 DNN installations), but with such an old DLL (0.6) we're worried about possible security issues.

I tried to just use a newer version of libwebp and was even able to compile it after messing around with visual studio, C compilers etc. but it's not compatible.

Could you update your connector to the latest version of libwebp? Would really appreciate it.

Many thanks! iJungleboy

@lilith
Copy link
Member

lilith commented Jun 11, 2020

Yes, this is in the backlog. Have you considered using Imageflow.Net instead? It uses the latest version of webp and supports much better jpeg compression as well.

@iJungleboy
Copy link
Author

I've considered it - I'm/we (2sic) are one of your backers ;) and really excited to see progress again.

ATM I'm still very hesitant to start. We are the makers of 2sxc - the most important CMS plugin for DNN, and we bundle ImageResizer with that. So switching resizers impacts somwhere between 10'000 and 25'000 websites which can disrupt stuff, + potentially cause quite some distress because of the AGPL nature of the ImageFlow.

So for my company 2sic it wouldn't be a problem - but it's hard to guess how all other users will be affected, which is why we're kind of scared to go that step.
We're also not sure if it will be a breaking change, if non-native DLLs will work (I believe that it can cause issues when run from UNC-shares, etc). So we're extremely cautious, but will look into that as it stabilizes.

That's why we're really hoping to get WebP to work asap.

BTW: as of now, we really had issues running it in DNN where the files are running on a UNC share, also because of the C++ dependencies which are usually missing on a "pure" hosting server . I'll explain more or create an issue if you're interested.

@lilith
Copy link
Member

lilith commented Jun 11, 2020 via email

@iJungleboy
Copy link
Author

Just created #257 and #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants