Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Semi-colon #220

Open
scuniff opened this issue Aug 10, 2023 · 0 comments
Open

Extra Semi-colon #220

scuniff opened this issue Aug 10, 2023 · 0 comments

Comments

@scuniff
Copy link

scuniff commented Aug 10, 2023

  1. ImageJ/Memory.java at master · imagej/ImageJ · GitHub

Semi-colon at end of 2’nd if statement creates an empty statement block so the return statement is always executed.

	if (max2>=limit && !IJ.is64Bit()) {
		if (!IJ.showMessageWithCancel(title, 
		"Note: setting the memory limit to a value\n"
		+"greater than "+limit+"MB on a 32-bit system\n"
		+"may cause ImageJ to fail to start. The title of\n"
		+"the Edit>Options>Memory & Threads dialog\n"
		+"box changes to \"Memory (64-bit)\" when ImageJ\n"
		+"is running on a 64-bit version of Java."));
			return;
	}

I think semi-colon should be removed:

		+"is running on a 64-bit version of Java."))
			return;

==================================

  1. ImageJ/Editor.java at master · imagej/ImageJ · GitHub

Here also I think semi-colon should be removed:

	if (Menus.getFontSize()!=0) ;
		mb.setFont(Menus.getFont());

should be :

	if (Menus.getFontSize()!=0) 
		mb.setFont(Menus.getFont());
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant