fix: add TypeScript definition to RoiManager #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpatiny wdyt? Should we merge for minimal typings? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## legacy #630 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 163 163
Lines 5698 5698
Branches 1424 1424
=======================================
Hits 4811 4811
Misses 790 790
Partials 97 97 ☔ View full report in Codecov by Sentry. |
bo-carey
commented
Oct 3, 2023
| @@ -328,7 +328,254 @@ export declare class Stack extends Array<Image> { | |||
| getMinImage(): Image; | |||
| } | |||
|
|
|||
| export declare class RoiManager {} | |||
There was a problem hiding this comment.
@targos I'm believe I got everything but let me know if you notice an error. Some return types are abstract until we get additional types like Shape, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.