Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setMatrix() return this object #621

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Yaceee
Copy link
Contributor

@Yaceee Yaceee commented Jun 14, 2023

Typing fix for setMatrix() function (Issue #607)

  • In src/image/utility/setMatrix.js, the function setMatrix() return the this object (similar to the setChannel() function).
  • In src/image/utility/setMatrix.js, add the return type to the setMatrix() function documentation
  • Adjust the type definition in index.d.ts

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8700b25) 84.43% compared to head (f75299b) 84.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           legacy     #621   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         163      163           
  Lines        5697     5698    +1     
  Branches     1424     1424           
=======================================
+ Hits         4810     4811    +1     
  Misses        790      790           
  Partials       97       97           
Impacted Files Coverage Δ
src/image/utility/setMatrix.js 85.71% <100.00%> (+1.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@targos targos merged commit b4ca38e into image-js:legacy Jun 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants