Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setMatrix(): Return this object #607

Open
gianluca-moro opened this issue Sep 20, 2022 · 1 comment
Open

setMatrix(): Return this object #607

gianluca-moro opened this issue Sep 20, 2022 · 1 comment

Comments

@gianluca-moro
Copy link
Contributor

In my Angular v14.2.3 project using node v16.14.0, I get the following
error TS7010: 'setMatrix', which lacks return-type annotation, implicitly has an 'any' return type.

To solve this, I just manually set the return type of setMatrix() in the index.d.ts to void.

I would like to propose the following changes:

  • In src/image/utility/setMatrix.js, the function setMatrix() should return the this object (similar to the setChannel() function). Currently it returns nothing, which is inconsistent with other functions.
  • In src/image/utility/setMatrix.js, add the return type to the setMatrix() function documentation
  • Adjust the type definition in index.d.ts
@PatricNox
Copy link

bump, same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants