Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: more typescript definitions #606

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Fix: more typescript definitions #606

merged 3 commits into from
Oct 7, 2022

Conversation

gianluca-moro
Copy link
Contributor

  • Added more Typescript definitions
  • Fixed some typos and wrong types in the paintLabels, painPolygon, paintPolygons and paintPolylines function documentations

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 84.43% // Head: 84.43% // No change to project coverage 👍

Coverage data is based on head (238eece) compared to base (7145692).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           legacy     #606   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         163      163           
  Lines        5697     5697           
  Branches     1424     1424           
=======================================
  Hits         4810     4810           
  Misses        790      790           
  Partials       97       97           
Impacted Files Coverage Δ
src/image/operator/paintLabels.js 0.00% <ø> (ø)
src/image/operator/paintPolygon.js 100.00% <ø> (ø)
src/image/operator/paintPolygons.js 100.00% <ø> (ø)
src/image/operator/paintPolylines.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos targos merged commit e4eb534 into image-js:legacy Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants