fix: add TypeScript definition to many methods #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## legacy #600 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 163 163
Lines 5697 5697
Branches 1424 1424
=======================================
Hits 4810 4810
Misses 790 790
Partials 97 97 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Please, merge this one. I created a PR right now for the GetChannel but this one is much more complete. Let's end this problem right now, right here. Please. |
|
I had a quick look and it seems good to me so I'm going to merge as-is. Thank you for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some type definition to some methods. Please check if I did something wrong since I am just a beginner to image-js.