Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Typescript definition to setChannel() method #597

Merged

Conversation

juninholiveira
Copy link
Contributor

@juninholiveira juninholiveira commented Jul 31, 2022

Please, merge this PR. I need the setChannel() method on my project and for some reason, it didn't have a definition. I just added one based on the doc.

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #597 (4cb9922) into legacy (b3b7499) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           legacy     #597   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         163      163           
  Lines        5603     5603           
  Branches     1397     1397           
=======================================
  Hits         4683     4683           
  Misses        820      820           
  Partials      100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b7499...4cb9922. Read the comment docs.

@targos targos merged commit 551c334 into image-js:legacy Aug 1, 2022
@juninholiveira juninholiveira deleted the feat/setchannel-type-definition branch August 1, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants