Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow rotate & crop for bitDepth = 1 images #596

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Conversation

Fa-b
Copy link
Contributor

@Fa-b Fa-b commented Jul 26, 2022

rotation of binary images did not fail but instead yielded weird output images.

Also includes:

  • add rotate processable check
  • fix crop processable check (announced process was 'max' on fail)

… crop processable check (announced process was 'max')
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #596 (0e14ce6) into legacy (b3b7499) will increase coverage by 0.85%.
The diff coverage is 96.94%.

@@            Coverage Diff             @@
##           legacy     #596      +/-   ##
==========================================
+ Coverage   83.58%   84.43%   +0.85%     
==========================================
  Files         163      163              
  Lines        5603     5697      +94     
  Branches     1397     1424      +27     
==========================================
+ Hits         4683     4810     +127     
+ Misses        820      790      -30     
+ Partials      100       97       -3     
Impacted Files Coverage Δ
src/image/transform/rotateFree.js 92.50% <92.45%> (+41.18%) ⬆️
src/image/transform/crop.js 100.00% <100.00%> (+6.66%) ⬆️
src/image/transform/rotate.js 100.00% <100.00%> (+7.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b7499...0e14ce6. Read the comment docs.

@lpatiny lpatiny self-requested a review July 26, 2022 11:58
@lpatiny
Copy link
Member

lpatiny commented Jul 26, 2022

Many thanks for your great contribution that looks very well done !

Would it be possible to add some testcases so that we don't have a reduction of the coverage ?

image

@Fa-b
Copy link
Contributor Author

Fa-b commented Jul 26, 2022

@lpatiny I have added some tests as requested

@targos targos merged commit 622b909 into image-js:legacy Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants