Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TypeScript definition for paintMasks() #591

Merged
merged 2 commits into from
May 17, 2022

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Apr 25, 2022

As with #587, this is a simple addition of another method (paintMasks()) to the TypeScript definitions.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #591 (a5118e4) into legacy (192058e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           legacy     #591   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         163      163           
  Lines        5603     5603           
  Branches     1397     1397           
=======================================
  Hits         4683     4683           
  Misses        820      820           
  Partials      100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192058e...a5118e4. Read the comment docs.

@incanus
Copy link
Contributor Author

incanus commented May 11, 2022

Hi, any movement on this? I know that development has shifted to another branch, but this is needed in the current stable version.

@targos
Copy link
Member

targos commented May 12, 2022

Hello, I cannot merge because of the linter error. You can run npm run prettier-write to fix it.

@incanus
Copy link
Contributor Author

incanus commented May 16, 2022

Ah — this was the case with my other recent PR #587 so I did not think it important. I will update the PR.

@targos targos merged commit 6edd169 into image-js:legacy May 17, 2022
@incanus incanus deleted the paintMasksTypeScript branch May 23, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants