Add option to ignore color palette in TIFF images #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add option flag to ignore the color table in type 3 TIF images that have indexed colors, returning index values as single channel, greyscale image instead of psuedo-colored, 3 channel RGB
Add option to ignore palette in TIF
targos
reviewed
Apr 10, 2022
There was a problem hiding this comment.
Can you please add a test to https://github.com/image-js/image-js/blob/legacy/src/image/core/__tests__/loadTIFF.js ?
- reuse palette in test table, with options - conditionally load with options
Codecov Report
@@ Coverage Diff @@
## legacy #589 +/- ##
==========================================
- Coverage 83.61% 83.58% -0.04%
==========================================
Files 163 163
Lines 5597 5603 +6
Branches 1394 1397 +3
==========================================
+ Hits 4680 4683 +3
- Misses 817 820 +3
Partials 100 100
Continue to review full report at Codecov.
|
Done. Not sure I understand what's going on with the code coverage, but if there's something I can do just let me know. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getImageFromIFDwill automatically create a 16 bit RGB if there if a tiff is of type 3. This makes sense most times, but occasionally, we need the raw single channel greyscale image.