Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added snippet to play video using javaFX #141

Closed
wants to merge 24 commits into from
Closed

Added snippet to play video using javaFX #141

wants to merge 24 commits into from

Conversation

RohitPatel1122
Copy link

@RohitPatel1122 RohitPatel1122 commented Oct 27, 2022 •
edited

  • Added code to play video via 3rd Party library JavaFX
  • Added required test case to validate valid and invalid file format
  • tested that build is passing locally.

Fix #109

@RohitPatel1122
Added media files
50079cc
@RohitPatel1122
Added code for play video
e162d99 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Added code snippet to README.md
ddc4b03 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Added code snippet to README.md
b3cc0f4 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Merge branch 'feat/media/play-video' of https://github.com/RohitPatel…
fcd7d33 
…1122/30-seconds-of-java into feat/media/play-video
@RohitPatel1122
Renamed test files
c6d383f 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Updated Test case to addition of new test resources
041a88b 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Copy link
Author

@iluwatar Build for some reason is taking long time to finish. Kindly review

@iluwatar
Copy link
Owner

iluwatar commented Nov 5, 2022

Please resolve the conflicts @RohitPatel1122

@iluwatar iluwatar self-assigned this Nov 5, 2022
@RohitPatel1122
resolved merge conflicts
2bade33
@RohitPatel1122
Fixed checkstyle issues
8365718 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
iluwatar
iluwatar requested changes Nov 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/main/java/media/PlayVideoSnippet.java Outdated Show resolved Hide resolved
src/main/java/media/PlayVideoSnippet.java Show resolved Hide resolved
src/main/java/media/PlayVideoSnippet.java Outdated Show resolved Hide resolved
@iluwatar
Copy link
Owner

With the new code, our CI seems to hang. Need to figure out what to do with that...

@RohitPatel1122
update as per review comments
64ad316 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@stale
Copy link

stale bot commented Dec 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale label Dec 24, 2022
@stale stale bot removed the status: stale label Jan 26, 2023
@iluwatar
Copy link
Owner

I think the code looks good, but we need to make the CI build pass. I tried to add JavaFX support in #158. Could you rebase this branch on top of master to check if it works now @RohitPatel1122 ?

@RohitPatel1122
Merge branch 'master' of https://github.com/iluwatar/30-seconds-of-java…
43bf0cc 
… into feat/media/play-video

� Conflicts:
�	README.md
�	build.gradle
@RohitPatel1122
Grdle file fix
59adaa0 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Copy link
Author

I have resolved the merge conflicts. But not sure, for what reason the build is failing. Kindly look into it.

@iluwatar
Copy link
Owner

iluwatar commented Feb 5, 2023

I needed to revert the CI change since it didn't work. Do you have any suggestions how to make Github Actions work with JavaFX?

@RohitPatel1122
Merge remote-tracking branch 'origin/master' into feat/media/play-video
443264a
@RohitPatel1122
Fix missing space
607687a 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Fix missing files assertion
857e523 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@RohitPatel1122
Copy link
Author

RohitPatel1122 commented Feb 25, 2023 •
edited

I needed to revert the CI change since it didn't work. Do you have any suggestions how to make Github Actions work with JavaFX?

What I understand is, Eclipse distribution temurin does not provide jdk+fx package. Check this.
While Zuul give it . Check this

We need to find way to install javaFX seperatly

@RohitPatel1122
Convert to zuul
6a4284d 
Signed-off-by: Rohit Patel <rohitpatel.1122@gmail.com>
@stale
Copy link

stale bot commented Mar 27, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale label Mar 27, 2023
@stale
Copy link

stale bot commented May 11, 2023

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this May 11, 2023
@iluwatar iluwatar mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar Awaiting requested review from iluwatar

Assignees

@iluwatar iluwatar

Labels
status: stale status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Play video file
2 participants
@RohitPatel1122 @iluwatar