disconnect between resource-backed model getters and async methods in current-user service

[stopfstedt]

i banged my head against this for a while today.

this is best explained by example:

from the current-user service class, consider this method:

  async isTeachingCourseInSchool(school) {
    const user = await this.getModel();
    const schoolCourseIds = school.hasMany('courses').ids();

    const courses = await user.get('allInstructedCourses');
    const matches = courses.filter((course) => schoolCourseIds.includes(course.get('id')));

    return matches.length > 0;
  }

take note of the async method call on the user model: await user.get('allInstructedCourses');

this invokes the User::allInstructedCourses getter - this is not a method that returns a promise, there is nothing to await on. it appears to always be returning an empty array when invoked in this manner.

there are several other examples of this kind of mismatch.

• CurrentUser::isTeachingCourse(course) is marred by the same problem
• CurrentUser::isTeachingSession(session) calls the User::allInstructedSession getter - same problem.

[stopfstedt]

another wrinkle - we don't have any test coverage on these methods.

$ egrep -r '(isTeachingCourseInSchool|isTeachingCourse|isTeachingSession)\(' packages/ | egrep -v '(dist|node_modules)'packages/ilios-common/addon/services/current-user.js:  async isTeachingCourseInSchool(school) {
packages/ilios-common/addon/services/current-user.js:  async isTeachingCourse(course) {
packages/ilios-common/addon/services/current-user.js:  async isTeachingSession(session) {
packages/ilios-common/addon/services/current-user.js:      (await this.isTeachingCourseInSchool(school))
packages/ilios-common/addon/services/current-user.js:    if (rolesToCheck.includes('COURSE_INSTRUCTOR') && (await this.isTeachingCourse(course))) {
packages/ilios-common/addon/services/current-user.js:    if (rolesToCheck.includes('SESSION_INSTRUCTOR') && (await this.isTeachingSession(session))) {